Closed redat00 closed 6 months ago
Hello, Thanks for your PR. I will start to review it !
Just finished editing all the thing you mentionned. Tests are passing fine on my local setup now. Let me know if I'm still missing something. Thanks!
Just finished editing all the thing you mentionned. Tests are passing fine on my local setup now. Let me know if I'm still missing something. Thanks!
Thanks ! I won't have a lot of time today sorry but I will start the CI as a first step.
Thanks for the CI !
I can see that I did not properly check for the error value of the rootCmd.Execute
method. The solution I can propose for this is the following :
if err := rootCmd.Execute(); err != nil {
fmt.Println(err)
os.Exit(1)
}
Do this looks fine to you ?
Thanks for the CI !
I can see that I did not properly check for the error value of the
rootCmd.Execute
method. The solution I can propose for this is the following :if err := rootCmd.Execute(); err != nil { fmt.Println(err) os.Exit(1) }
Do this looks fine to you ?
Oh yes ! Linter is cool to check those :) . Yes I'm fine with it. That will through an error only when a not found command is used so it is great to not use the logger.
No more linting error, should have ran the lint command on my local setup before committing, would have saved us some times!
:tada: This PR is included in version 4.14.0 :tada:
The release is available on:
v4.14.0
Your semantic-release bot :package::rocket:
Issue/Feature
version
command that allows to easily see what version of the package we're using. Previously this was only visible when the server was starting.conf/
, but now we can also specify the path we want.Additional Information
Nothing is suppose to break, as the usage stay the same : Not specifying any command will start the server, just like it's currently done, and the default value for the configuration folder is also still the same. If I missed anything, please let me know.
The only downside of this PR is that it adds a new dependencies to the project in the form of Cobra.
Checklist: