oxyplot / oxyplot-sharpdx

MIT License
16 stars 10 forks source link

Update appveyor.yml #25

Closed Jonarw closed 4 years ago

Jonarw commented 4 years ago

After #22 appveyor pushed the package as Version 2.0.0 to MyGet. This was unintended and due to my lack of knowledge of CI stuff. With this I'm trying to get the version number to the 2.0.0-unstable.xxx format we also use for the other oxyplot components.

@oxyplot/admins

Jonarw commented 4 years ago

One step closer I guess...? But why is the build version something like '18-otoyiuyi'? Is this something that must be set up separately in appveyor? I will investigate some more... If you happen to know an easy fix, could you take a look @objorke? Thanks!

objorke commented 4 years ago

I would suggest to build the same way as the core library: https://github.com/oxyplot/oxyplot/blob/develop/appveyor.yml#L16

Remove https://github.com/oxyplot/oxyplot-sharpdx/blob/master/appveyor.yml#L21

And generate package on build https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot.Wpf/OxyPlot.Wpf.csproj#L6

Delete https://github.com/oxyplot/oxyplot-sharpdx/blob/master/Source/OxyPlot.SharpDX.Wpf/OxyPlot.SharpDX.Wpf.nuspec

Jonarw commented 4 years ago

That is pretty much what I tried to do in this PR. I think you looked at the master branch, which doesn't reflect my changes (btw. can we change it so develop is the default branch?).

If you take a look at: https://github.com/oxyplot/oxyplot-sharpdx/pull/25/files#diff-180360612c6b8c4ed830919bbb4dd459

I pretty much copied the configuration of the core library for this, and generally it seems to work. The only weird thing is that we end up with a version like 2.0.0-unstable.18-otoyiuyi...

objorke commented 4 years ago

I have changed default branch. I think it is aligned with the core library now. We have the same kind of version numbers there now (the latest is 2.1.0-unstable.1379-vamuwgtk).

objorke commented 4 years ago

Thanks!

Jonarw commented 4 years ago

Ah I wasn't aware of that. Thanks for your help!