search

oxyplot / oxyplot-xamarin

OxyPlot for Xamarin.Mac and Xamarin.Forms
MIT License
64 stars 59 forks source link

Update OxyPlot.Core to 2.1.0 #142

Closed janusw closed 1 year ago

janusw commented 1 year ago

This updates OxyPlot.Core from 2.0.0 to 2.1.0 and implements the necessary API changes. It should fix #124.

It would be great if some OxyPlot maintainer could have a look at this. @objorke @VisualMelon

janusw commented 1 year ago

Did some basic checks with the nupkg built from this PR today, using a Xamarin.Forms app that shows a simple LineSeries plot. This kind of plot is still rendered correctly on Android and iOS. :+1:

VisualMelon commented 1 year ago

Looking through the code quickly, nothing looks off; I'd suggest you double-check the bar series example: you may need to qualify the axis keys.

janusw commented 1 year ago

Looking through the code quickly, nothing looks off

Thanks for the review!

I'd suggest you double-check the bar series example: you may need to qualify the axis keys.

Indeed the BarSeries example in the SimpleDemo app was failing at runtime. I fixed it now by qualifying the axis keys, as you suggested. With that addition, this PR should be complete, I guess.