search

oxyplot / oxyplot

A cross-platform plotting library for .NET
https://oxyplot.github.io/
MIT License
3.26k stars 957 forks source link

Remove example/debug specific [C|R] key down bindings from default controller #1467

Open maettu-this opened 4 years ago

maettu-this commented 4 years ago

Change description

I propose to remove the [C|R] key down bindings. While really cool together with the examples or debugging, they are rather peculiar. Why remove? [ + C] is an often used shortcut, and [Alt + ] bindings may make troubles in certain cultures. And for debugging one can easily add them. Or, make the bindings [DEBUG] conditional.

objorke commented 4 years ago

I think the only key bindings are "Home", "A" and "Ctrl+Alt+C" https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot/PlotController/PlotController.cs#L32

We could consider to remove them, but this is a breaking change.

I think it is OK to use the default Copy command pattern in WPF: https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot.Wpf/PlotBase.cs#L105

But is it correctly implemented for WinForms? https://github.com/oxyplot/oxyplot/blob/develop/Source/OxyPlot.WindowsForms/PlotView.cs#L103