oxyroid / M3UAndroid

Open Source Player, which made of jetpack compose. Android 8.0 and above supported.
https://t.me/m3u_android
Apache License 2.0
216 stars 24 forks source link

Channel icon are broken if they are not in the same size as the box in TV. #127

Closed mohitkyadav closed 3 weeks ago

mohitkyadav commented 3 weeks ago

Describe the bug I have a playlist with channel icons which are not in the rectangular format. They are transparent images with the exact dimensions of the channel. For example here's one for sky news:

sky

To Reproduce Steps to reproduce the behavior:

  1. Add a playlist with any items, set the icon/poster to this: https://github.com/tv-logo/tv-logos/blob/main/countries/united-kingdom/hd/sky-news-hd-uk.png?raw=true

Expected behavior The channel box should not crop the image on TV. It should work how it works in the mobile app.

Screenshots ss

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

oxyroid commented 3 weeks ago

OK. I will fix it

mohitkyadav commented 3 weeks ago

Thank you @oxyroid , it's a great app. I tried contributing myself but I'm not experienced in Kotlin. That's not the biggest issue, I'm having this issue right now, When I make a change in the code, the changes do not hot reload, do you know how to enable that or I'll have to rerun it even after changing one line. Maybe you can tell me how to fix these, will make the development hella easier.

I'm using Android studio on MacOs + Android Emulator.

oxyroid commented 3 weeks ago

You can check this.

https://developer.android.com/develop/ui/compose/tooling/iterative-development#live-edit

And I think it is a very unstable feature for now. So I don't use it and rerun application after changing one line. 🙃

mohitkyadav commented 3 weeks ago

You can check this.

https://developer.android.com/develop/ui/compose/tooling/iterative-development#live-edit

And I think it is a very unstable feature for now. So I don't use it and rerun application after changing one line. 🙃

Wow, it must have been very tough so far 😅, respect 🙌 . Okay I'll try the live edit thanks.