search

oxyroid / M3UAndroid

FOSS Player, which made of jetpack compose. Android 8.0 and above supported.
https://t.me/m3u_android
Apache License 2.0
450 stars 43 forks source link

Fix bug 190: Brightness & Volume gestures only work when controls are… #200

Closed tungnk123 closed 1 month ago

tungnk123 commented 1 month ago

Fix bug 190: Brightness & Volume gestures only work when controls are are displayed

oxyroid commented 1 month ago

The touch areas are somewhat confusing.

There are overlapping areas, making it difficult for users to control volume/brightness or dismiss the mask. The red area is not visible on the mask, and the green area covers the red area beneath the mask, all scroll events are intercepted by the green area.

photo_2024-10-03_00-30-59 photo_2024-10-03_00-31-04 photo_2024-10-03_00-31-06 photo_2024-10-03_00-31-08

tungnk123 commented 1 month ago

Do you mean that the users are confused because the volume/brightness control area (green area) overlaps with the mask visibility toggle area (red area)? Shouldn't the mask only appear when users tap in the center of the screen, while swiping on the sides should adjust brightness and volume without showing the mask? And when swiping, users don't want the mask to appear and disrupt their experience, right? Could you pls suggest me some solution for this problem?

oxyroid commented 1 month ago

The user should be able to tap to show or hide the controls and swipe to adjust the volume and brightness, regardless of whether the controls are visible. Ensure some areas of the top layer remain empty to allow tap events to reach the bottom layer, and there’s no need to restrict the width of the bottom layer.

oxyroid commented 1 month ago

And in other hands, the controls layer in the front of the gesture layer has also scroll event need to be consume in the center so that we can enter the EPG panel. So

  1. tap the any position to show and hide controls whatever the controls is visible or not.
  2. swap the left or right sides to control the volume and brightness whatever the controls is visible or not.
  3. swap the center area to expand the EPG panel whatever the controls is visible or not.
tungnk123 commented 1 month ago

@oxyroid I have just pushed the new commit. Could you pls check it for me pls? Thanks very much for these comments ❤