search

oyachai / HearthSim

Generic Hearthstone game simulator
MIT License
316 stars 59 forks source link

DeckFactoryTest.checkIncludeSpecifiedCardsUnlimitedCopies() sometimes fails the second assertion #117

Closed slaymaker1907 closed 9 years ago

slaymaker1907 commented 9 years ago

For some reason, this test method has been failing on the second assertion (and seemingly only on the second assertion) 1 out of every couple hundred runs.

slaymaker1907 commented 9 years ago

The error also exists for DeckFactoryTest.checkIncludeSpecifiedCardsLimitedCopies().

slaymaker1907 commented 9 years ago

Bug was in the test since it didn't account for the fact that the included cards could be the same card.

The bug should be fixed in my latest pull request.

oyachai commented 9 years ago

Thanks for looking into it.