Coding styles

[MrHen]

I noticed that gradle uses checkstyle and I can set that up to be more aggressive about unifying code style. Right now there are apparently a bunch of differences between our IDEs. What do you want for:

• Tabs versus spaces (and if spaces, how big?)
• Position of { after a new block (e.g., if(blah && other) {). Common choices are same line or new line.
• Are braces necessary for a one-statement block? I.e., should if(truthy) doSomething; be if(truthy) { doSomething; }?
• Spacing around keywords such as if, for (e.g. if (thisMinionPlayerSide == damagedPlayerSide) { versus if(thisMinionPlayerSide == damagedPlayerSide) {
• Spacing around constants. (E.g., Eclipse keeps trying to reformat new DeathrattleDamageAll((byte) 2) into new DeathrattleDamageAll((byte)2).)
• Should references to class variables require this.foo?
• Should we have newlines at the end of files?

There are obviously lots of other settings but these are the ones I've seen matter recently.

[oyachai]

My preferences are:

• 4 spaces
• same line
• not necessary
• space after
• don't care for spaces around constants
• Don't really want to keep writing this.blah
• new line at EOF

I'm not at all married to any of those preferences though. Happy to accommodate other patterns.