File reorganization - Githubissues

oyachai / HearthSim

Generic Hearthstone game simulator

MIT License

314 stars 59 forks source link

File reorganization #90

Closed MrHen closed 9 years ago

MrHen commented 9 years ago

How do you feel about reorganizing how the card files are laid out? If we group things by:

Set
Rarity

Then our subfolders won't continue to grow and grow as we implement new cards. It's already getting to be somewhat of a pain to deal with all of the Minion cards living in the same folder.

oyachai commented 9 years ago

Yep, I agree.

Do you have any particular preference for ordering?

cardtype.set.rarity.CardName
set.cardtype.rarity.CardName
other permutations

If there are no preferences, I would go with set.cardtype.rarity.CardName.

MrHen commented 9 years ago

I think set.cardtype.rarity.CardName works.

oyachai commented 9 years ago

Will push in the next couple of days.

MrHen commented 9 years ago

Alright; I'll hold off on any refactoring then. :)

oyachai commented 9 years ago

done!

oyachai commented 9 years ago

reminder to myself: GUI is probably broken due to this change.

MrHen commented 9 years ago

Yeah, looks like the CardFactory isn't working anymore. Created https://github.com/oyachai/HearthSim/issues/104 to track the problem.