search

oyd11 / LPC.jl

Linear predictive coding, Julia module
MIT License
0 stars 0 forks source link

Permission to incorporate this code into other packages #1

Open staticfloat opened 7 years ago

staticfloat commented 7 years ago

Hey there @oyd11. Would you give permission for me to include this lpc_burg function in a more general package, such as DSP.jl? I think it would be very useful alongside other spectral estimation methods I'm planning on contributing to that package.

oyd11 commented 7 years ago

Sounds great, so firstly - go ahead!

I also meant to add more spectral estimation methods (and documentation and tests for this one) [ specifically - there's a spectral-reassignment method I've implemented and not uploaded yet, and a filter-design pack ]

oyd11 commented 7 years ago

So @staticfloat : when you actually do that - let me know, so that I'll make any updates / tests etc on a fork of DSP.jl or wherever you end up incorporating these functions into, thanks!

staticfloat commented 7 years ago

@oyd11 A cool 5 months later, I've actually opened a pull request, as you can see linked above.

oyd11 commented 7 years ago

thanks @staticfloat ! I'll join and monitor the package discussion, add relevant tests there, it'll be great seeing this refactored into the DSP package!