oyejorge / less.php

less.js ported to PHP.
http://lessphp.typesettercms.com
Apache License 2.0
655 stars 2 forks source link

Semantic versioning #246

Open nazar-pc opened 9 years ago

nazar-pc commented 9 years ago

Can you use semantic versioning, please? This 1.7.0.7 looks really weird and doesn't exmplain well what happened with new release. http://semver.org/

oyejorge commented 9 years ago

If it just "looks weird", then I don't see a big reason to change. Here's how to read the less.php versions:

Version numbers can be viewed as LESSJS.LESSPHP

oyejorge commented 9 years ago

Dup of #155

nazar-pc commented 9 years ago

Semantic versioning allows you do this, for instance, I'm using following: MAJOR.MINOR.PATCH+build-BUILD_NUMBER. So you can use it like LESSJS+less.php-LESSPHP or something similar, just to follow rules. It is not a big reason, but semantic versioning is really nicely described, well known and self-explaining, so I decided that it might be a good thing to adopt here. Obviously, it is up to you, as maintainer, to use it or not.

oyejorge commented 9 years ago

So instead of 1.7.0.7, it sounds like you're suggesting `1.7.0+build-7``. Is that right?

nazar-pc commented 9 years ago

Yes, it might be so (but I'm using it primarily for own projects and build number is always increasing). Taking third-party thing (as basis or dependency) I usually add shortcut of own project and build number. So, it might be as 1.7.0+lp7 where lp is less.php. Basically you can put anything after +, moreover, if you'll try to compare 1.7.0+lp1 with 1.7.0+lp2, latter will be correctly understood as newer.

mwjames commented 9 years ago

If it just "looks weird", then I don't see a big reason to change. Here's how to read the less.php versions:

Well, those who rely on it as a library mostly understand the interpretation of a 1.7.1 or 1.8.1 as:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

It is not so much about "looks weird" but to make it easier for users to conceive an awareness about possible breakages or bug fixes based on the common semver.

paladox commented 9 years ago

Maybe do something like

LESSJS+less.php-LESSPHP

like was suggestion so like one release for bugfixes and another for new features that is just for less.php and not used by less.js or based on less.js or is based on it.