oyelakinG9 / my_portfolio

My Portfolio Project is a Microverse project that covers HTML, CSS, and basic JavaScript. It contains a skeleton, a work section, an about and contact page. It's strictly made with flexbox for better page layout. A form is available in the contact form section for easy communication.
https://oyelaking9.github.io/my_portfolio/
MIT License
0 stars 0 forks source link

chore: Test linter config #17

Closed oyelakinG9 closed 2 years ago

oyelakinG9 commented 2 years ago

Add window popUp to the ptoject

oyelakinG9 commented 2 years ago

I have conflict issues with the former pull request, so I made a new pull request to resolve the merging conflicts.

ShoiraTa commented 2 years ago

STATUS: CHANGES REQUIRED 🟡

Hi team,

:thumbsup: This is good to make it this far, your project is really nice, congratulations on the good work you have done so far. The popup behaves as expected. Kudos on your JS 👏🏻👏🏻👏🏻

Keep on coding, good job so far! :clap:

There are some issues that you still need to work on to go to the next project mostly to do with the styles.

Required Changes :recycle:

Yours Figma
image image
Yours Figma
image image
Yours Figma
image !image

Cheers and Happy coding! :clap: :clap: :clap:

Code review by Shoira

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

oyelakinG9 commented 2 years ago

Hi @ShoiraTa
I've modified those areas and everything Is working perfectly now.