search

oyiptong / up-headliner

Headliner is a JSON API that returns personalized content obtained from providers
Mozilla Public License 2.0
0 stars 2 forks source link

Merging settings; tests structure #18

Closed diogobaeder closed 10 years ago

diogobaeder commented 10 years ago

This change makes the settings object merge with the provided options, instead of replacing the whole provided dictionary, so that the user doesn't need to copy all of the default elements in the custom options file. For example, for the nytimes API we just need "api_key" to be provided as a new option, while the other default options work fine, so it's best to ask the user to just provide "api_key".

Also, this pull request changes the tests structure to reflect the production package structure, so that it's easier to find out the path to a package while walking from the tests to the production code and vice-versa. It also helps with deciding where to place new test modules, and to name them.

oyiptong commented 10 years ago

Looks good. Could you please change the isinstance location? I'll then merge.

Thanks!

diogobaeder commented 10 years ago

No worries, man, thanks a lot for the help!