search

oyooyo / keyble

Command line tools and library for controlling eqiva eQ-3 Bluetooth smart locks
90 stars 28 forks source link

Remove duplicate declaration and signing to itself #45

Closed schlagmichdoch closed 1 year ago

oyooyo commented 1 year ago

Thanks a lot for finding these little bugs, I seriously just wondered wtf I did there ;-)

schlagmichdoch commented 1 year ago

classic 😄 Actually my IDE told me these when I checked out what to do to make keyble more stable again. Any suggestions where to begin?

oyooyo commented 1 year ago

Nothing that immediately comes to my mind. I still assume that certain issues actually stem from the Bluetooth LE library that keyble uses but which got abandoned several years ago, but I do not know about any Bluetooth LE library for Node.js that could replace it.

schlagmichdoch commented 1 year ago

According to the package.json you switched to @abandonware/noble a while ago where errors seem to be actively fixed. Do you think the library is buggy per se?

With node-ble there seems to be another ble library for node which has been actively developed since 2020: npmjs github repo

Any idea whether migrating would increase stability?