search

oyranos-cms / oyranos

Colour Management System
https://gitlab.com/oyranos/oyranos
Other
18 stars 6 forks source link

oyranos-0.9.5 /src/modules/oyranos_cmm_oyIM_profile.c:941: possible bad comparison ? #11

Closed dcb314 closed 9 years ago

dcb314 commented 9 years ago

oyranos-0.9.5/src/modules/oyranos_cmm_oyIM_profile.c:941:48: warning: comparison of constant '12' with boolean expression is always false [-Wbool-compare]

error = !mem || !oyProfileTag_GetSize(tag) > 12;

Suggest add (). Maybe

error = (!mem) || (oyProfileTag_GetSize(tag) <= 12);

beku commented 9 years ago

thanks for reporting and the patch

is in commit #b6a45ae80d53dd2cae174fa20233f717e28598ec