search

oysstu / pyimc

Python bindings for Inter-Module Communication Protocol (IMC)
Other
9 stars 6 forks source link

Generating bindings from a already existing build package #1

Open krisklau opened 7 years ago

krisklau commented 7 years ago

Hi,

I really like the functionality of this module!

When I develop with DUNE, I usually have a build folder (with a generated package containing all libraries/include files, using make package). In stead of re-building dune when generating the python bindings, should it not be possible to simply use this folder? IMC can be put in this folder as well, using make imc_download.

I wanted to take a crack at this myselves, but I am not to familiar with the Extensions framework.

Best regards, Kristian

oysstu commented 7 years ago

Hi,

Yes, my original build system involved setting environmental variables to a pre-built repository. I'm in favor of changing the current build system to both be simple with the ability to set custom DUNE/IMC repos. I'm leaning towards either having a setup.cfg file in the root directory, where these paths can be set, or implementing something with the CMake ExternalProject functionality. I think the former can be implemented without too much trouble.

Regards, Øystein

krisklau commented 7 years ago

Hi,

True, it seems like the former is a good idea that maintains the simplicity of the current system by reverting to upstream repos if no paths are specified :)

In case you are unfamiliar with this (at least I were), an install-directory can be specified when running cmake for dune, which will generate a installed base with all header-files and compiled dune-core library. Steps to generate this is given here: https://github.com/oceanscan/ros-imc-broker/issues/2

(I were previously using make package, which does a very similar thing, just adds the root to a more convoluted default location)

Kristian