search

oysterprotocol / oyster-streamable

Streamable implementation of the Oyster protocol. WIP!
4 stars 0 forks source link

[Streamable] Don't use a config file #19

Closed rfornea closed 6 years ago

rfornea commented 6 years ago

Oyster-streamable has a config file with a specific address for downloading. This is inconvenient for testing/QAing, since you have to go into the node_modules and change that address to some different brokernode. Ideally, oyster-streamable shouldn't have a config--it would just use the config values from whatever project is consuming streamable.

CKH4 commented 6 years ago

I'll do this. It will be a required option when you create a new Download object. This will be in line with how it is handled in the Upload.

Edit. After looking at it, we no longer use those variables. It should work from the passed provider