search

oysterprotocol / webinterface

Web interface that enables a user to upload a file via the Oyster Protocol
GNU General Public License v3.0
35 stars 5 forks source link

[Webinterface] Fix code climate suggestions once fully migrated to streams #182

Open AaronVasquez opened 6 years ago

AaronVasquez commented 6 years ago

The recommendations will go away once the old code is deleted. It's not worth "refactoring" until then.

jfarago commented 6 years ago

I want to take a look at configuring the reporting on the other projects too, code climate seems to show "false positives"

jfarago commented 6 years ago

@AaronVasquez can you link a report with errors we want to ignore?

AaronVasquez commented 6 years ago

https://codeclimate.com/github/oysterprotocol/webinterface/pull/183

I think the long functions thing is too restrictive. Especially since a reducer will be long due to matching a bunch of actions.

@pzhao5 can you link to which golang rules you think are too strict?