search

oyyd / youdao-collins-chrome-extension

A chrome extension to help you search english words in collins dict.
MIT License
147 stars 27 forks source link

fix: issue/39 Uncaught TypeError: Cannot read property 'nodeName' of … #65

Open futurist opened 2 years ago

futurist commented 2 years ago

this PR should fix: https://github.com/oyyd/youdao-collins-chrome-extension/issues/39

The logic retuned:

  1. When firstElementChild is empty, the returned value should be checked against null
  2. When it's not INPUT or TEXTAREA, then fallback to range.getBoundingClientRect