Various Features - Githubissues

oz / tz

🌐 A time zone helper

GNU General Public License v3.0

849 stars 33 forks source link

Various Features #47

Closed wyne closed 2 months ago

wyne commented 2 months ago

Summary

Fix: Update times as you move
New: Jump by day with H / L
New:Jump by week with < / >
New: Add -w for watch mode, updating every minute
New: Right align times for easier reading; add month and year
New: Press o to open in timeanddate.com
New: Press t to go to now

Demo

Top: Current Bottom: New

https://github.com/user-attachments/assets/106bb105-92ee-4c99-866e-278d88e366dd

Resolves #39 Resolves #40 Resolves #10

oz commented 2 months ago

Hi!

First, thanks for these changes, and recording a demo. 👍🏻

I really want to merge this, but I see a failing test right now. Something with date change not happening at midnight. I'll take a look later, unless you beat me to it.

wyne commented 2 months ago

It's probably my latest commit that resolved a bug where it would skip over a day at midnight (ex: Wed->Fri). So something is off between the UI and the test.

I'll take a look.

wyne commented 2 months ago

I was confused about the distinction between model.now and Now, so I consolidated the clocks into one unified clock. That made sense to me, but let me know if I'm missing something.

I'm still debugging the test though. I had it working at some point, but still hitting an issue even though it does work correctly in the TUI.

wyne commented 2 months ago

Ah, I figured it out in the latest commit. Lmk if you have a better idea. I don't do a lot of go programming :)

oz commented 2 months ago

Lmk if you have a better idea. I don't do a lot of go programming :)

Me neither lately. 😞

Alright. That PR works for me. Thanks a lot! 🙇🏻