search

oz / tz

🌐 A time zone helper
GNU General Public License v3.0
851 stars 33 forks source link

Configuration file support (TOML) tests are missing #68

Closed jnd-au closed 1 month ago

jnd-au commented 1 month ago

TOML config file support (and associated logging) was recently added to tz (#1) but it lacks unit tests:

  1. It reduced HEAD unit-test coverage from 42% to 31%, and reduced coverage from 84% to 73% in PR #62.
  2. It introduced user-impacting changes of behaviour, bugs, or blockers like: #63 #65 #66

Therefore, config file parsing is a significant surface area for unit testing.

Furthermore, testing is needed for the configuration environment-variable support, but this is already included with bugfixes in PR #62.

jnd-au commented 1 month ago

Furthermore, the config file functions need to be parameterised to unblock unit testing.