Closed MichaelXavier closed 1 month ago
ConstraintKinds we could do type CSV s r = (FromCSV s r, IntoCSV s r)
I think the most salient reason not to bother with this is that it doesn't have to live in the library. Anybody that wants to defer migration or migrate incrementally from the unified class to the split class can add the constraint alias themselves. I don't have an objection to the extension itself because I use ConstraintKinds
prolifically for database stuff.
This looks very old, and the participants seem to have not converged on a decision. I'm going to close it, but feel free to reopen.
This is for #24
@ozataman @bitemyapp please weigh in. Relevant explanation from the commit log:
I decided to scrap the idea at least in this first attempt of preserving the CSV class. It is really easy to upgrade and we would definitely put this behind a breaking change. Once I got into the code I realized keeping the CSV class would mean either:
Thanks to the split, it allowed me to add a NamedE variant of Named that does not erase parse errors and provide only the parsing instance without having to provide a nonsensical serialization instance.