search

ozataman / csv-conduit

Flexible, fast and constant-space CSV library for Haskell using conduits
Other
52 stars 32 forks source link

Add the option to not quote empty strings #48

Closed clintonmead closed 3 months ago

clintonmead commented 1 year ago

This hack is due to this strange behaviour of BigQuery:

https://stackoverflow.com/a/38023252/525980

Ideally, we'd add an option to only quote string where required, i.e. when they contain commas, quotes or newlines. But that is significantly more complex, so we just handle the empty string case here.

I understand if you don't accept this PR. It's a breaking change, and it only fixes a peculiar requirement. However I thought I was offer the changes to upstream just in case.

ysangkok commented 1 year ago

The devs don't seem responsive, and given that it isn't compatible with ghc-9.6, I think it would be best if somebody took over the package. Would you like to do that, @clintonmead ? Otherwise I might do it at some point.