ozdemirburak / full-name-generator

Generate random names using data from popular names and surnames of various countries.
https://fullnamegenerator.com
MIT License
23 stars 15 forks source link

Add Thai Names and Surnames #17

Closed ozdemirburak closed 11 months ago

ozdemirburak commented 11 months ago

The repository is missing Thai names and surnames. Follow the guide below to add them.

🚀 How to Contribute:

  1. Fork the repository.
  2. Add names and surnames for your country following the format provided below.
  3. Submit a Pull Request with your changes.
  4. Please include a reliable source for the names and surnames you're adding, preferably a public database or a reputable website.

📄 Format:

For names (src/names/th.ts):

const thaiNames = {
    0: [ // Male names - Add the URL of the names source here
        'Name1', 'Name2', 'Name3', ...
    ],
    1: [ // Female names - Add the URL of the names source here
        'Name1', 'Name2', 'Name3', ...
    ]
}

export default thaiNames;

For surnames (src/surnames/th.ts):

const thaiSurnames = [ // Add the URL of the surnames source here
    'Surname1', 'Surname2', 'Surname3', ...
];

export default thaiSurnames;

📌 Important Notes:

RileeyL commented 11 months ago

Hi @ozdemirburak could i please be assigned to this? Thanks!

ozdemirburak commented 11 months ago

Sure, actually, there's no need to ask. As long as anyone follows the guidelines, I'm OK with merging any pull request.

RileeyL commented 11 months ago

@ozdemirburak I made two pull requests because i wasnt sure how to merge them, is there a way to merge my pull requests so that the surnames and names are in the same pr?

ozdemirburak commented 11 months ago

Not a problem. Thanks.