Possible password reset issue.

ozdemirburak / laravel-9-simple-cms

Laravel 9 content management system for starters.

MIT License

686 stars 302 forks source link

Possible password reset issue. #112

Closed safarovitch closed 3 years ago

safarovitch commented 3 years ago

setPasswordAttribute is a function supposed to set password as encrypted hash when register happens via User model. As the function was necesary in previous versions of laravel, in laravel8 it may couse serious problems as malfunctioning of Password Reset Functions of laravel auth.

https://github.com/ozdemirburak/laravel-8-simple-cms/blob/794b52b671f4f916481a2385c7402138a2a1689f/app/Models/User.php#L43

ozdemirburak commented 3 years ago

I'd be happy to accept your PR that will fix this issue.

safarovitch commented 3 years ago

Well at this point I am not sure the solution I applied for my project is applicable in every other situation since I inclıded laravel ui auth onto the login controllers of this project. Anyways the solution for me was simply to remove mentioned line of code.