search

ozee31 / cakephp-cors

A CakePHP (3.3+) plugin for activate cors domain in your application
MIT License
43 stars 31 forks source link

Upgrade to cakephp 4.0 #23

Closed octisfall closed 4 years ago

octisfall commented 4 years ago

ozee31/cakephp-cors v1.1.7 requires cakephp/cakephp >=3.3.2 <4.0.0

Do you plan to upgrade the plugin ?

ozee31 commented 4 years ago

Yes, I plan to migrate when I have some time.

OneHatRepo commented 4 years ago

Please do this. It's needed for a project. Thanks!

chrisShick commented 4 years ago

I didn't see any major changes to the middleware layer of Cake 4.x. Shouldn't this work without any changes considering the CakePHP 3.x style invokable double pass middlewares are still supported for backwards compatibility.

chrisShick commented 4 years ago

@ozee31 @octisfall @OneHatRepo I have created a pull request to update this plugin to Cake 4.x

https://github.com/ozee31/cakephp-cors/pull/24

chrisShick commented 4 years ago

@ozee31 any updates here?

ozee31 commented 4 years ago

https://github.com/ozee31/cakephp-cors/pull/24

Thanks @chrisShick and @rchavik