Rename Tournament module to TournamentSystem,

ozfortress / tournament-system

A ruby gem that implements various tournament systems.

MIT License

18 stars 8 forks source link

Rename Tournament module to TournamentSystem, #6

Closed pawelma closed 6 years ago

pawelma commented 6 years ago

Tournament is too generic name.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 99.0% when pulling fb9b7ac53c042bdbf9db729dcb5055237c67176f on pawelma:master into 693eb45dfa3f39fd1d3647fe6d90d3abb871792b on ozfortress:master.

coveralls commented 6 years ago

Coverage decreased (-0.7%) to 99.0% when pulling c721a6f49f3ae97f1b839c1e0cd1c8ad35bccff0 on pawelma:master into 693eb45dfa3f39fd1d3647fe6d90d3abb871792b on ozfortress:master.

BenjaminSchaaf commented 6 years ago

Thanks for the pull request. I completely agree that Tournament is too generic, but I have some issues with the proposed changes:

Folder names should follow the same naming schema as ruby, thus tournament_system is preferred over tournament-system.
TournamentSystemSystem is not an OK name, it should really be just TournamentSystem
It doesn't pass rubocop.

BenjaminSchaaf commented 6 years ago

I've made these changes myself. This will require a major version increment to stay in-line with Semantic versioning.

ghost commented 6 years ago

Yep major bump is required in did.

Sorry that I didn't manage to fix the code but I was overwhelmed with other stuff. Thanks for update tho.

BenjaminSchaaf commented 6 years ago

No worries. May I ask what you're using this gem for? It would be nice to know :)

ghost commented 6 years ago

I was working on small chess project and I used this for tournaments pairing (using swiss::dutch method).

BenjaminSchaaf commented 6 years ago

Awesome. It's nice to know my work has been useful to others. Thanks for sharing.

If you've got some thoughts on how to improve this library (or anything really), do feel free to add an issue.

ghost commented 6 years ago

OK. Will do.