show message at agent pos on out of board action

ozkriff / zemeroth

😠⚔️😈 A minimalistic 2D turn-based tactical game in Rust

https://ozkriff.itch.io/zemeroth

Apache License 2.0

1.4k stars 87 forks source link

show message at agent pos on out of board action #665

Closed estin closed 3 years ago

estin commented 3 years ago

Hi! This PR fixed panic by assert!(self.is_inboard(pos));

Case:

demo battle
choose alchemist
choose healing
click out side of map

Solution: on out of board click - show cancelled message at agent pos

Sorry for my poor English

ozkriff commented 3 years ago

Thanks for the PR but I think it's better to add the missing checks into MessageMap's methods, otherwise messages in other parts of the codebase may panic too. Closing in favor of #666