ozmartian / vidcutter

A modern yet simple multi-platform video cutter and joiner.
GNU General Public License v3.0
1.8k stars 136 forks source link

Appdata.xml in two places #137

Open lgbaldoni opened 6 years ago

lgbaldoni commented 6 years ago

In 5.5.0 vidcutter.appdata.xml is created both in /usr/share/appdata and /usr/share/metainfo. The new location is preferable, the old one is still ok, but apparently not both at the same time.

Perhaps a switch is required?

martinkg commented 6 years ago

I think copying to usr/share/appdata is no longer needed. see also fedora packages guide https://fedoraproject.org/wiki/Packaging:AppData

$ grep -r vidcutter.appdata.xml *
vidcutter-5.5.0/_packaging/appimage/VidCutter.yml:  - cp ../../../../data/appdata/com.ozmartians.vidcutter.appdata.xml usr/share/appdata
vidcutter-5.5.0/_packaging/appimage/VidCutter.yml:  - cp ../../../../data/appdata/com.ozmartians.vidcutter.appdata.xml usr/share/metainfo
vidcutter-5.5.0/_packaging/fedora/vidcutter.spec:%{_datadir}/appdata/com.ozmartians.vidcutter.appdata.xml
vidcutter-5.5.0/_packaging/fedora/vidcutter.spec:%{_datadir}/metainfo/com.ozmartians.vidcutter.appdata.xml
Übereinstimmungen in Binärdatei vidcutter-5.5.0/__pycache__/helpers.cpython-36.pyc
vidcutter-5.5.0/helpers.py:                ('/usr/share/appdata', ['data/appdata/com.ozmartians.vidcutter.appdata.xml']),
vidcutter-5.5.0/helpers.py:                ('/usr/share/metainfo', ['data/appdata/com.ozmartians.vidcutter.appdata.xml']),
lgbaldoni commented 6 years ago

Unless perhaps for older systems that don't support appdata inside metainfo?