search

ozmartian / vidcutter

A modern yet simple multi-platform video cutter and joiner.
GNU General Public License v3.0
1.78k stars 134 forks source link

mpv has removed support for opengl_cb API and now vidcutter cannot compile #345

Closed PhobosK closed 2 years ago

PhobosK commented 2 years ago

Hi MPV has already removed the support for the opengl_cb (https://github.com/mpv-player/mpv/commit/632059816adde518c67f6606e3cfdef5bec18b52) and now vidcutter doesn't compile:

gcc -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -DOPENSSL_LOAD_CONF -fwrapv -fno-semantic-interposition -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -fPIC -I/usr/include/python3.8 -c vidcutter/libs/pympv/mpv.c -o build/temp.linux-x86_64-3.8/vidcutter/libs/pympv/mpv.o -g0
vidcutter/libs/pympv/mpv.c:630:10: fatal error: mpv/opengl_cb.h: No such file or directory
  630 | #include "mpv/opengl_cb.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

Tumbleweed already moved to the new libmpv2

Thanks

easyteacher commented 2 years ago

The package is going to be removed from Tumbleweed if it continues failing compiling.

ozmartian commented 2 years ago

VidCutter was updated and switched from opengl_cb to MPV's new render API about 2 years ago. Perhaps there is some unneeded dependency in place somewhere.

ozmartian commented 2 years ago

Its an issue with pympv, a dependency. Should have this resolved sometime soon.

ozmartian commented 2 years ago

I've just pushed a new commit with 3 changes to files in the pympv libs folder. These are simple patches, commenting out deprecated stuff from libmpv that aren't needed for this project anyway. Have tested it against latest mpv-git code so should be all good.

Have let OpenSUSE Leap package admin know. Not too sure where to go for Tumbleweed though?

easyteacher commented 2 years ago

I have submitted a request for it. Thank you very much!

https://build.opensuse.org/request/show/956575

ozmartian commented 2 years ago

Champion. Thx!

easyteacher commented 2 years ago

Tested, no problem cutting videos.

ozmartian commented 2 years ago

Awesome. Thanks so much for your help!