ozmartian / vidcutter

A modern yet simple multi-platform video cutter and joiner.
GNU General Public License v3.0
1.77k stars 137 forks source link

Save Media hangs when using Frame Accurate Cutting #384

Open chrisveness opened 1 year ago

chrisveness commented 1 year ago

From the log:

2023-06-08 17:24 - vidcutter.libs.videoservice - INFO - /app/bin/ffprobe -hide_banner -v error -show_packets -select_streams v -show_entries packet=pts_time,flags -of csv "/home/xxxxx/Videos/video.mp4"
2023-06-08 17:24 - root - CRITICAL - 
  File "/app/lib/python3.9/site-packages/vidcutter/videocutter.py", line 1361, in saveMedia
    self.smartcutter(file, source_file, source_ext)
  File "/app/lib/python3.9/site-packages/vidcutter/videocutter.py", line 1406, in smartcutter
    self.videoService.smartcut(index=index,
  File "/app/lib/python3.9/site-packages/vidcutter/libs/videoservice.py", line 331, in smartcut
    bisections = self.getGOPbisections(source, start, end)
  File "/app/lib/python3.9/site-packages/vidcutter/libs/videoservice.py", line 590, in getGOPbisections
    end_pos = bisect_left(keyframes, end)

2023-06-08 17:24 - root - CRITICAL - <class 'TypeError'>: '<' not supported between instances of 'str' and 'float'

Versions:

avalon60 commented 1 year ago

This makes it very difficult to use. I'm on Linux Mint 21.1 and editing down vids is almost impossible. Disabling the smartcut, seems to make the process very innacurate.

mrehkopf commented 1 year ago

I have the same issue. Solution has been part of a pull request for quite some time: https://github.com/ozmartian/vidcutter/pull/183/commits/bcbf88034693bfb401481f232607b3bfcec72127 However it is not being merged. I had no success building the app on MSYS2/mingw64, maybe someone else can try it out :)

derickso commented 8 months ago

I built using the code from that pull request and it still hangs with Frame Accurate Cutting enabled.

amymor commented 5 months ago

same here hope someone fix it