search

ozntel / file-explorer-note-count

Obsidian Plugin for viewing the number of elements under each folder within the file explorer
101 stars 18 forks source link

Does not run since last update of today #16

Closed merlinuwe closed 1 year ago

merlinuwe commented 1 year ago

Let me guess: You have adapted it to the new insider release 1.2?

I cannot install it again on android

Xiaomi Poco X3 pro.

Error messages:

Failed to load plugin

Failed to unload plugin

MrBertie commented 1 year ago

Same problem here, Samsung A71

follnet commented 1 year ago

Downgrade the version from 1.2.1 to 1.2.0

looneyapache commented 1 year ago

Same, Not working anymore

looneyapache commented 1 year ago

Downgrade the version from 1.2.1 to 1.2.0

No , That too doesn't work (at least for me)

merlinuwe commented 1 year ago

(At windows 10 I haven't upgraded the plugin; it works.)

Profile8647 commented 1 year ago

Remove data.json from the plugin's directory if you downgraded and it should work. Note this will reset your preferences.

looneyapache commented 1 year ago

Remove data.json from the plugin's directory if you downgraded and it should work. Note this will reset your preferences.

I dont have data.json anywhere in given directory tree ( I am on Ubuntu 22 and use Obsidian AppImage community edition)

willasm commented 1 year ago

Same here. Downgrading to 1.2.0 is working. v1.2.1 is intended for Obsidian v1.2.0 which is still in preview at this point in time. Will wait until Obsidian update is released before trying this again.

YousufSSyed commented 1 year ago

How do you downgrade versions?

ozntel commented 1 year ago

Unfortunately, the mobile version of Obsidian doesn't validate the minimum version required for the plugin. You can see below that the minimum Obsidian version for the latest plugin update is "1.2.0":

https://github.com/ozntel/file-explorer-note-count/blob/8966745644bbcaef1fb758d8d771e3a59dd9b674/versions.json#L8

My recommendation is to use the Obsidian BRAT plugin to install the previous version of the plugin as fixed until Obsidian releases the next public version. It should only happen on mobile. The desktop should work fine since it will use the Obsidian version requirement.

willasm commented 1 year ago

@YousufSSyed You can download any version by clicking on releases from the code page. I just overwrote the newer version with the files from release 1.2.0. The files are in the folder YourVaultName\.obsidian\plugins\file-explorer-note-count

YousufSSyed commented 1 year ago

Unfortunately, the mobile version of Obsidian doesn't validate the minimum version required for the plugin. You can see below that the minimum Obsidian version for the latest plugin update is "1.2.0":

https://github.com/ozntel/file-explorer-note-count/blob/8966745644bbcaef1fb758d8d771e3a59dd9b674/versions.json#L8

@ozntel What is the version.json file? Look at it, it doesn't make sense.

Also, I'm on deskop and had updated to version 1.2.1 which is broken. Can you fix it?

looneyapache commented 1 year ago

Finding out what went wrong in my situation took some time.

The most recent version, in my view, removed my earlier plugin folder (file-explorer-note-count), created an entirely new folder called folder-plugin-core (by aidenlx probably new requirements by latest plugin), and then put the latest plugin inside of it.

Apparently, despite deleting and re-copying version 1.2.0, this was the reason the plugin wouldn't function.

I deleted folder-plugin-core and then restored old copy and it worked.

ozntel commented 1 year ago

Please delete and install the plugin again. It should work now properly. Thanks!

merlinuwe commented 1 year ago

You have downgraded from 1.2.1 to 1.2.0?

ozntel commented 1 year ago

You will get 1.2.1 update once Obsidian has its next public release

merlinuwe commented 1 year ago

Late, but works perfect. Tested it on Windows 10 and Android 11.

Thank you very much!

Oneechan69 commented 1 year ago

Unfortunately, the mobile version of Obsidian doesn't validate the minimum version required for the plugin. You can see below that the minimum Obsidian version for the latest plugin update is "1.2.0":

https://github.com/ozntel/file-explorer-note-count/blob/8966745644bbcaef1fb758d8d771e3a59dd9b674/versions.json#L8

My recommendation is to use the Obsidian BRAT plugin to install the previous version of the plugin as fixed until Obsidian releases the next public version. It should only happen on mobile. The desktop should work fine since it will use the Obsidian version requirement.

@ozntel I'm going to be blunt, I think you could've handled this overall situation better You had released an update your plugin for a pre-release verison of Obsidian and broke for nearly everyone that was on the latest stable version, it costs $$ to get insider builds. Sure you may not have realized that, but you shouldn't have responded saying to downgrade it with BRAT. You caused a problem with your plugin and basically told others to fix it themselves.

What about non tech-savvy users that didn't think to go to the GitHub page or see this bug? They were just left with a broken plugin that they then uninstalled and or were unhappy about being broken. You could've rolled back the update, maybe make a new release that undoes the changes. You could've also released the update on the day it came out or soon after, or make the update a pre-release as described here: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release.

I just hope you learned from this and don't do something like that again.

ozntel commented 1 year ago

Unfortunately, the mobile version of Obsidian doesn't validate the minimum version required for the plugin. You can see below that the minimum Obsidian version for the latest plugin update is "1.2.0": https://github.com/ozntel/file-explorer-note-count/blob/8966745644bbcaef1fb758d8d771e3a59dd9b674/versions.json#L8

My recommendation is to use the Obsidian BRAT plugin to install the previous version of the plugin as fixed until Obsidian releases the next public version. It should only happen on mobile. The desktop should work fine since it will use the Obsidian version requirement.

@ozntel I'm going to be blunt, I think you could've handled this overall situation better You had released an update your plugin for a pre-release verison of Obsidian and broke for nearly everyone that was on the latest stable version, it costs $$ to get insider builds. Sure you may not have realized that, but you shouldn't have responded saying to downgrade it with BRAT. You caused a problem with your plugin and basically told others to fix it themselves.

What about non tech-savvy users that didn't think to go to the GitHub page or see this bug? They were just left with a broken plugin that they then uninstalled and or were unhappy about being broken. You could've rolled back the update, maybe make a new release that undoes the changes. You could've also released the update on the day it came out or soon after, or make the update a pre-release as described here: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release.

I just hope you learned from this and don't do something like that again.

@Oneechan69 This is not the place to argue but please be careful with your statements and better not be blunt like you started your message. I am not doing it for any financial benefits and I need to prioritize my day-to-day jobs rather than something I do as a hobby when I have spare time. I never force anyone to use the plugins that I release. If you are not happy with the plugins, I would recommend finding alternatives that suit you. And btw this issue is not as easy as you think. Obsidian changed the way how file explorer works in the insider version. It was broken for many insiders and I could not wait for the next public version to be released before I fix this issue. There was an issue with the manifest file that I realized later on and I worked on it as you can see on my discord message: https://discord.com/channels/686053708261228577/840286264964022302/1102162318030274611 I hope this makes sense and, again please be careful when you approach people like me who do development without any financial expectations. It just makes me sad that people can not appreciate it...