search

oznu / docker-cloudflare-ddns

A small amd64/ARM/ARM64 Docker image that allows you to use CloudFlare as a DDNS / DynDNS Provider.
https://hub.docker.com/r/oznu/cloudflare-ddns/
GNU General Public License v3.0
1.08k stars 219 forks source link

update period/conditions #34

Closed Sigi-cz closed 4 years ago

Sigi-cz commented 4 years ago

not really an issue ... could You please describe in the readme what is the dns update period / conditions?

StrictLine commented 4 years ago

I'd also appreciate it, because I guess at the moment, it's hard coded, right? root/etc/services.d/crond/run: /usr/sbin/crond -f -l 8 -d 6

I'm new to the docker, that's why I cannot make you a solution proposal/PR.

Sigi-cz commented 4 years ago

based on this #11 it runs every 5 minutes (and it does) but it would be nice to have it in README.md so users don't need to search closed issues for that info.

StrictLine commented 4 years ago

You're right, thanks for refering! This should be the permalink for the line where this is set up: https://github.com/oznu/docker-cloudflare-ddns/blob/3d19e54c211b9ccbf8546900da41b56c262962b9/root/etc/cont-init.d/30-cloudflare-setup#L91

StrictLine commented 4 years ago

it'd be more elegant to define an environment variable instead of the hard-coded 5.

ghzgod commented 4 years ago

it'd be more elegant to define an environment variable instead of the hard-coded 5.

I agree with this, for now I edited it using crontab -e command and changing it to 10. I too would like an environment variable to set the interval.

Edit: like you mentioned, I edited the 30-cloudflare-setup file instead so it is persistent across container reboot.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Dulanic commented 4 years ago

Submitted a PR for that a ability to customize. We'll see if accepted. Also would then document the default.