ozodrukh / CircularReveal

Lollipop ViewAnimationUtils.createCircularReveal for everyone 4.0+
MIT License
2.43k stars 391 forks source link

CircularReveal does not have any effect running on Android 5.1 #31

Closed tounaobun closed 9 years ago

tounaobun commented 9 years ago

It is weird that running on Android 5.1,ViewAnimationUtils.createCircularReveal does not have any animation starting.

ozodrukh commented 9 years ago

well, it works on my phone furthermore on Genymotion emulator too, can you share any piece of code

yhsj0919 commented 9 years ago

device: mi2 system: miui6,android5.0.2 Have the same problem

ozodrukh commented 9 years ago

Guys, can you share code that you are running?

yhsj0919 commented 9 years ago

you can see that it's a old version . you can replace the new code https://github.com/yhsj0919/YHUtils/tree/master/YHUI

marbat87 commented 9 years ago

I confirm that it doens't work on Android 5.0 or above (tested on 5.0 and 5.1.1).

My code is the following:

                rootView.findViewById(R.id.consegnati_view).setVisibility(View.INVISIBLE);
                View myView = rootView.findViewById(R.id.choose_view);
                myView.setVisibility(View.VISIBLE);
                // get the center for the clipping circle
                int cx = myView.getRight();
                int cy = myView.getTop();
                // get the final radius for the clipping circle
                int finalRadius = Math.max(myView.getWidth(), myView.getHeight());
                SupportAnimator animator =
                        ViewAnimationUtils.createCircularReveal(myView, cx, cy, 0, finalRadius);
                animator.setInterpolator(new AccelerateDecelerateInterpolator());
                animator.setDuration(CIRCLE_DURATION);
                animator.start();

The purpose is to hide "consegnati_view" and reveal the "choose_view" from the top right corner. They're inside the same parent "io.codetail.widget.RevealFrameLayout" in my xml.

It works perfectly on Android versions below 5.0

ozodrukh commented 9 years ago

marbat87, hm interesting remark, i will try to figure out today

tounaobun commented 9 years ago

@ozodrukh I think the code I wrote is correct,because it runs successfully below Android L.Maybe it is a problem of compatibility.Hope you can fix it.Thanks.:-)

ozodrukh commented 9 years ago

Well actually I made a commit relative to this issue, and some sample, cab you check out them, if everything is fine I will made release it On May 30, 2015 2:55 PM, "Benson" notifications@github.com wrote:

@ozodrukh https://github.com/ozodrukh I think the code I wrote is correct,because it runs successfully below Android L.Maybe it is a problem of compatibility.Hope you can fix it.Thanks.:-)

— Reply to this email directly or view it on GitHub https://github.com/ozodrukh/CircularReveal/issues/31#issuecomment-107017625 .

efemoney commented 9 years ago

I'll like to add that it doesn't work for me too 5.0 and 5.1 but works pre-L.

I don't know how to get the fix from github thought.Could you help me

ozodrukh commented 9 years ago

Can you clone repository and check out new version (it is not released in jitpack)

y3seker commented 9 years ago

I can confirm that last changes are working on 5.1.1, thanks for it.

ozodrukh commented 9 years ago

Great :+1:
i'm closing this issue for now, if something happen please re-open it and provide some more information will wait for 2 day and will release new version

aashreys commented 9 years ago

When will the update be released?

devspacenine commented 9 years ago

Can confirm that version 1.1.1 works on Android 5.1.1. @aashrey99 it is now in jitpack

ozodrukh commented 9 years ago

Thanks guys for help :+1: