Hide Dock while Message Tray is showing

[kyuucr]

When Message Tray is hiding, the dock is forced to show, even if the dock supposed to be hidden

[kyuucr]

Now the dock is hidden when it supposed to be appear. I have made a patch from your commit. I moved the showing-hiding event handling to intellihide.js and in atomdock.js, remove box hover status when Message Tray showing.

[cldx]

Oddly enough, with the patch it doesn't work for me at all anymore.

[cldx]

Moved to Intellhide like in the patch, i tweaked around some more and so far this works pretty good on my end. i'm on 3.10 btw

[me4oslav]

I will test on 3.12.

[tomvanderlee]

It doesn't pop up again after the message tray is closed.

[ndyakov]

I will review this later.

[cldx]

@phantom94 It doesn't pop up again after Message Tray is closed when you're on the Desktop?

Here's what it does for me:

Desktop View: I open Dock, expand Message Tray, dismiss Message Tray by clicking anywhere on the Desktop. It never returns to the Dock cause the Mouse is outside of the Dock.

It might be nice if the Dock returns cause you might have accidentially opened the Message Tray, i guess this is a question of "expected behavior". So how do we even want to handle that?

[tomvanderlee]

Yes, when I'm on the desktop, same way you did. I also should say I'm on Gnome 3.12.

[satya164]

Shouldn't the dock shift up like everything else when message tray is open? It'll feel weird to have all other elements slide up and only the dock hiding. We have to maintain consistency.

[cldx]

@satya164 Probably yes, the idea of this pull request was to provide a temp fix to make the Message Tray usuable at ALL for the time being. I'm not sure if it will be very complicated to have it shift up, maybe it's a trivial thing to do.

[me4oslav]

It nukes the dock on my 3.12. :/

[cldx]

Ugh, i gotta get a 3.12 Testing Environment, its kinda frustrating to always wait for feedback just to hear it's breaking.

Have some error output?

[me4oslav]

Would love to provide you with one. The only hiccough is that I have no clue how to do so. P.S. You are scaring me when you disappear from Hangouts for a few days. :D

[satya164]

@me4oslav Alt+F2, then type lg, click on Extensions and then Show errors

[me4oslav]

Ok, I figured why it was nuking the extension for me - my folder was @numixproject.org and not @ozonos.org Anyways, what it does now is it works properly (intelide) and then if I invoke the message tray it hides and after I exit message tray mode it stays in autohide mode.

[cldx]

Yes, this is a bit of pain alltogether, lets try something different.

I completely nuked the intellihide stuff and instead the Dock will shift up with everything else, it might be a bit hackish cause i mess with actor groups, but it's closer to what @satya164 said, more consistency. And i don't have to mess with AutoHide.

As a side effect, Notifications should now display ON TOP on the Dock, not behind it, which is not beautiful but it's better than not getting Notifications at all. Give me a little time to do some cleanup and i'll push it.

Usually when i disappear i'm just "in the zone", so i always leave my Cell away from me and don't go to GPlus and such cause it just distracts me.

[cldx]

All good for testing....i hope...

[me4oslav]

It works like a charm on 3.12. \o/ If it also works on 3.10, I guess somebody should press the big fat green merge button. BTW, @cldx check the team at numixproject.org email. There is important email about Team-Database icons.

[cldx]

I'll wait for @ndyakov to review it cause he's the master of cleanup.

I can confirm it's running on 3.10 though

[me4oslav]

Metallica made master of puppets, but we have ... master of code clean up.

[tomvanderlee]

Works like a charm on 3.12!

[ndyakov]

Something is not okey with your indentation, but don't worry. If this is working - merge the pull request, I will create a new pull request later with the cleanups.

[cldx]

You still have to tell me cause otherwise i won't see it :)

[me4oslav]

So, who will press the Merge button?