search

ozonos / atom-dock

Custom Dock for Ozon Desktop
GNU General Public License v3.0
72 stars 13 forks source link

Fix code style, so JSHint is happy. #24

Closed ndyakov closed 10 years ago

ndyakov commented 10 years ago

Please double test, because I have no way of testing the extension itself.

kyuucr commented 10 years ago

Tested in 3.12 and looks okay. I was particularly worried about showLabelFunction being moved outside of class but I think it's alright :+1:

tomvanderlee commented 10 years ago

It works on 3.12! @kyuucr You want to press the button? :p

ndyakov commented 10 years ago

@phantom94 @kyuucr Let someone else tests as well, then we can merge.

kyuucr commented 10 years ago

@phantom94 We need someone to test for 3.10 first :p

me4oslav commented 10 years ago

@cldx Can you test on 3.10?

kyuucr commented 10 years ago

Tested on 3.10, there's mistypes that causes popover menu to not appear

ndyakov commented 10 years ago

@kyuucr right, I missed that.

ndyakov commented 10 years ago

@kyuucr Can you test again?

kyuucr commented 10 years ago

Tested and works on 3.10 and 3.12 :+1: