search

ozonos / atom-dock

Custom Dock for Ozon Desktop
GNU General Public License v3.0
72 stars 13 forks source link

Intellihide implemented! #4

Closed kyuucr closed 10 years ago

kyuucr commented 10 years ago

Kindly, please do test it :))

Also added words to AUTHORS and README

ndyakov commented 10 years ago

There are few places with commented out code that should not be pushed to the repository. Also please use more useful commit messages.

me4oslav commented 10 years ago

I just tested it and from testing point of view, it is greenlit.

tomvanderlee commented 10 years ago

It works on my end, but the dock doesn't hide all the way. It sticks a few pixels above the screen edge. I don't know whether this is intended, because it doesn't say anything about it in the design document.

I agree with @ndyakov about the comments, please remove the useless ones. Other than that, it is ready to merge.

kyuucr commented 10 years ago

@ndyakov sorry, I was intending to keep the comments for when we implement settings. But I will remove some of it anyway because after taking a look on it again, you're right, the comments are very ugly. @phantom94 yes, it was my design consideration, I could make it hide all the way if everyone wants it

tomvanderlee commented 10 years ago

@kyuucr I just talked to @me4oslav, he still needs a design specification for that. You can leave it for right now.

kyuucr commented 10 years ago

Pushed code cleanup :)

me4oslav commented 10 years ago

Yeah, we still need design for that intellhide indication. Until we have work work on implementing per workspace active apps behaviour (and option to disable it). Also - https://plus.google.com/u/0/b/114059589828649263886/114059589828649263886/posts/AFJZWp4VqtT

kyuucr commented 10 years ago

Was trying to clean up, ended up with fixing drag and drop behavior and app label placement Btw, @me4oslav great job on the PR side! :+1:

me4oslav commented 10 years ago

Leave it to me to oversell projects. :3

tomvanderlee commented 10 years ago

Works and code looks fine by me. I think it can be merged.

ndyakov commented 10 years ago

I know i'm a little late and the pull request is merged, but: Good job! :+1: