search

ozonos / atom-dock

Custom Dock for Ozon Desktop
GNU General Public License v3.0
72 stars 13 forks source link

Implement :overview pseudo-class for Dock #6

Closed cldx closed 10 years ago

cldx commented 10 years ago

This is an enhancement report and can be triggered whenever the time to do so is available.

Please implement a :overview pseudo-class for the Dock which can be targeted from a User Theme, just like it is used in the original Gnome Shell Panel.

Rationale: Adding a pseudo-class has the benefit of making a clean implementation in the stylesheet for having a transparent Dock in Overview without us having to hack CSS from the Extension's javascript.

The default theme shall have this from the get-go.

It also makes it very simple for third party devs to adapt their themes to Atom Dock with the least amount of work and without breaking support of their themes for a vanilla Gnome Shell install. Themes that don't support the pseudo-class will just degrade gracefully.

kyuucr commented 10 years ago

Do we have an example gnome-shell theme that implement :overview pseudo-class? Last time I check ozon-shell it's not implementing it. I need it to adjust the theming so it will display correctly on vanilla gnome-shell and themed ones.

cldx commented 10 years ago

There is a pull requests pending for Ozon Shell Theme that add the :overview class.

There is no example, cause up until now #dash:overview never existed, if a theme doesn't provide an :overview class it will just fall back to using the default Dash Styles. Ozon Shell now has it (after merging the pull request) other Theme Maintainers should be encouraged to support it in their themes (most likely in a G+ Post), but they dont have to and nothing will break.

This way we can stay true to the initial design vision without having to override custom User Themes or messing with CSS in Javascript too much.

kyuucr commented 10 years ago

Implemented and merged ozonos/atom-dock#7