search

ozonos / atom-launcher

A simplified App Launcher without categorisation and with applications sorted by frequency
GNU General Public License v3.0
19 stars 6 forks source link

Bring up to initial spec #1

Closed mpnordland closed 10 years ago

mpnordland commented 10 years ago

These commits bring nos-dash to feature completeness according to the spec. imports.ui.appDisplay.AllView was forked and modified for the app view, and the rest is done in extension.js

ndyakov commented 10 years ago

@cldx Please write if the code is tested before merge. Also it will be good to give the developer some feedback.

mpnordland commented 10 years ago

@ndyakov This pull request is closed, please create an issue. We need to do some more discussion on the review process.

cldx commented 10 years ago

@ndyakov It was tested and works fine. Since it was the first pull request with any functional code in any of the nos-extensions i didn't really bother to write a lengthy report. I believe we will have enough iterations to discuss in the future :). But you're right, i broke the review process doing that. So, Excuses.

For future pull requests i'll resort to just give my 2 cents in the comments unless it's a really trivial thing to merge. However you can be sure i won't merge stuff that i'm not certain of being non-breaking.

@mpnordland Nice Job mate. Working as expected. I'll create the Issue mentioned above since i was the one acting too fast on this.