Atom dash doesn't work in GNOME 3.12

[satya164]

I cannot even enable it due to error in loading. I guess it's some API incompatibility.

Here is a screenshot showing the error message in looking glass,

[tomvanderlee]

I've checked it out.. did not find a solution (yet). It appears that the _redisplay() method is removed from the appDisplay class.

[satya164]

Probably I had seen the same (or similar?) issue in Atom dock before it was compatible with GNOME 3.12. May be you can check what changed there?

[angel-araya]

@phantom94, nope, redisplay is still in 3.12. Here the source.

Btw, hi, I'm out of hospital again :smiley:

[tomvanderlee]

@arayaq, it sure is (multiple times) in the appDisplay.js file. But not in the AppDisplay class (Line 735-843).

Also, Hi!

[mpnordland]

Hey all, I'm investigating this. I'm updating my dev vm to 3.12 and I've got a branch made to fix this.

[me4oslav]

YAY.

[angel-araya]

A little summary of the changes of 3.12 I found regarding this:

• _redisplay removed from AppDisplay class (as @phantom94 noted)
• _redisplay implemented in the abstract class BaseAppView.
• _redisplay implemented the class FolderIcon (does not inherit from BaseAppView)
• _redisplay is still in the class AppIconMenu (does not inherit from BaseAppView)

Hope this makes a point to start from.

[satya164]

You are on Ubuntu, right?

I use Fedora, which has a more vanilla GNOME, and it doesn't work here.

On 16 April 2014 17:39, xyl0n notifications@github.com wrote:

I'm running Gnome 3.12 with the extension enabled fine here.

Reply to this email directly or view it on GitHubhttps://github.com/ozonos/atom-dash/issues/6#issuecomment-40591211 .

Satyajit Sahoo Profile - Facebook http://facebook.com/satya164, Google+http://plus.google.com/u/0/114564489020097923600 Artwork - DeviantArt http://satya164.deviantart.com

[mpnordland]

@xyl0n I'd like to see the output of gnome-shell --version on your machine.

[me4oslav]

@xyl0n Works as in the behaviour demoed here? https://plus.google.com/u/0/b/114059589828649263886/114059589828649263886/posts/LPmtssozhoy @mpnordland It also wors for me, but all it does is make the All Apps section empty. But then again my 3.12 is hacky installed one on Ubuntu, so we can not trust it.

[mpnordland]

@me4oslav That's not a working version. Since the way the views work is so different, I'm just going to keep the current one for 3.10 and fork All Apps from 3.12. I've got a way to pick the right one when we load so it shouldn't be a problem. The only issue would be that behavior wouldn't be shared, but I don't know how that'd be possible anyways.

[me4oslav]

@mpnordland Well, it doesn't crash, so I call it working. :> ... Albeit in working in useless way. Anyways, ignore my 3.12 for Dash testing, because it is installed in super hacky way, its Dash is kindd broken, so it is no safe to accept any testing data from it about the Dash.

[xyl0n]

@satya164 @mpnordland @me4oslav Sorry, I was on the wrong page. I accidentally clicked on atom-dash instead of atom-dock. I'm not using this extension right now but I have Arch running on Gnome 3.12 where I could test it.

[me4oslav]

@xyl0n Lay off the rakija, bro, and test it. :D

[mpnordland]

Preliminary compatibility has been achieved, for 3.12 there is no frequency sorting yet, but 3.10 should still be fully functional (untested). You can try this out in the 6-3.12-compat branch. just run make install and it should overwrite the current install. 3.12 should hide the frequent apps view and the view switcher. The all view should work as it does in vanilla shell. 3.10 should work as before.

[me4oslav]

I can confirm. Ace job! :) Now, frequency sorting, pleaseeee. :3

[satya164]

Yeah. Works.

P.S: There is no animation while opening the dash. We should smoothly transition to the dash view.

[me4oslav]

@satya164 I think we use "transition-duration: 500ms; for animation, so we should use that for Dash opening animation too.

[satya164]

@me4oslav 500 is very much. Feels slow.

We use 100 for normal items, but for overview, we can make it 300.

[satya164]

BTW the animation duration is not important. How it will happen is important. The windows should smoothly fadeout and the dash should fadein.

[mpnordland]

@satya164 @me4oslav please create a separate issue for that

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[satya164]

@mpnordland Okie dokie.

[xyl0n]

On Gnome 3.12 on Arch and extension still doesn't work. I install it, restart shell but Gnome Tweak Tool reports "error loading extension" :(

[me4oslav]

@xyl0n Are you testing the 6-3.12-compat branch?

[xyl0n]

@me4oslav ...no I'm not. Such stupid. Much noob. DX

[me4oslav]

@xyl0n I did tell you to lay off the rakija, you silly cat! :D

[tomvanderlee]

@xyl0n, your post was missing something: :wink:

[me4oslav]

@phantom94 Nope. @xyl0n is in fact a cat, not a dog.

[me4oslav]

It works now.