search

ozontech / dtrack-audit

OWASP Dependency Track API client for intergration into CI/CD pipeline
GNU General Public License v3.0
51 stars 16 forks source link

Add teamcity support v2 + refactoring #11

Closed agentram closed 3 years ago

agentram commented 3 years ago

Hi,

I made some updates for TeamCity output and tried to refactor config generation. Sorry if this is too much of a change - when I started, one thing pulled another and so on...

This is how TC build looks now: Screenshot 2021-01-28 at 11 49 00 It contains information about all tested libraries (total number of tests) and failed tests for libraries with vulnerabilities. You can also see a description of the vulnerability in the test output.

oxdef commented 3 years ago

Hi!

Thanks for the MR and sorry for delay. If you don't mind I suggest to split it into separate small ones: config and TeamCity support v2.

agentram commented 3 years ago

No problems, I will prepare a MR for config soon.

agentram commented 3 years ago

I will merge https://github.com/ozonru/dtrack-audit/pull/11 in this branch when it's approved

oxdef commented 3 years ago

@agentram Sorry for the delay. I've just merged config PR and made some changes in release branch. Could you please move teamcity support code into /internal/dtrack/ package like for https://github.com/ozonru/dtrack-audit/blob/release/v1.0.0/internal/dtrack/config.go?

agentram commented 3 years ago

Hi @oxdef I have updated the PR. Let me test it in my builds for a few days.

agentram commented 3 years ago

@oxdef Everything is alright. You can review it.