search

ozwillo / ozwillo-kernel

GNU Affero General Public License v3.0
5 stars 1 forks source link

Need for a "portal_id" field in app_instance documents ? #28

Closed bobeal closed 5 years ago

bobeal commented 5 years ago

When logging out from a non default portal, the brand is not recognized.

After looking at the code, and especially https://github.com/ozwillo/ozwillo-kernel/blob/52f38badf300a9e5ef0315e214d3ea601bf6b36f/oasis-webapp/src/main/java/oasis/web/authn/LogoutPage.java#L176 and https://github.com/ozwillo/ozwillo-kernel/blob/52f38badf300a9e5ef0315e214d3ea601bf6b36f/oasis-model/src/main/java/oasis/model/applications/v2/AppInstance.java#L186, it appears app_instances need a portal_id field for the branding to work (which has been confirmed on the integration platform).

Is this the expected behavior ?

tbroyer commented 5 years ago

Yes, it's the expected behavior.

The property will be set (by the MarketBuyEndpoint) when instantiating an application. For portal instances, I felt it easier to add that property when (manually) creating the instance than to special-case them in code.