search

ozwillo / ozwillo-portal

Ozwillo's user portal
https://www.ozwillo.com
GNU Affero General Public License v3.0
1 stars 2 forks source link

Integrate geographical data (country, city, postal code) into users profiles #280

Closed bobeal closed 8 years ago

ilucatero commented 9 years ago

See issue #230 (labelled as v1.1)

bobeal commented 9 years ago

@ilucatero yes, and there are one or two others on the same subject. I'll close them and keep this one when I have some time (or you can do it if you want).

And, most probably, the React porting of the profile screen will be done in a future iteration.

ilucatero commented 8 years ago

Remark : I just found that regarding the address labels, for some languages the field City it is called different (en/locality, fr/ville, ca/Municipi,es/Municipio, it/Città, tr/Yerleşim Yeri {translated as place}).

@OzBruno / @bobeal So for this changes, what is the value that should be showed in the option list : Cities or Regions? I am ok with Cities which make more sense, but in any case the translations should be changed in order to not confuse the user.

OzBruno commented 8 years ago

The address of the profil is exactly the same as the address of an organisation : a person living in France has to select a "city" if the UI language is en, a "ville" if the UI language is fr. But a person living in Turkey has to select a "District" if the UI language is en or fr (same label) and a "İlçe" if the language is tr. You may propose to user to select the nuts3 (Départment, Province) before so the city/District field will search only into the city/District of the selected nuts3.

bobeal commented 8 years ago

@ilucatero (cc @OzBruno) and, by the way, it should be more logical that the order in which the user fills the fields be :

  1. Country
  2. Nuts3 (optional field)
  3. City (filtered according to the chosen country above)
  4. Zip (pre-filled with the city's zip if possible)
  5. Address
ilucatero commented 8 years ago

@OzBruno So to be clear with the requirement: the approach for the locality field in Profile page is the same as with cities in organization modal (mentioned by you up above) and also described as :

The current process in the organizations modal is to filter cities by country and the modelType "addrpostci:PostalCity_0" which includes districts and cities.

If localities and cities are the same in this context, there I can reuse the service call to query the cached geo data (which NOT includes the field nuts3, but the mentioned modelType).