ozzeD / omaha

Automatically exported from code.google.com/p/omaha
Apache License 2.0
0 stars 0 forks source link

Google Updater Should be Friendlier #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
From my dad:

---
Looking at the windows task manager a few minutes ago due to high cpu
usage, I saw that a task consisting of a series of numbers, followed
by what looking like "google updater".  Then a moment later, that
stopped and "setup.exe" took over with high cpu.

I assume that the updater kicked off setup.exe.

Some days ago, I also found a setup.exe running with high cpu.
Concerned I had picked up a virus, I immediately killed it.  Today's
experience made me think that occurrence was another "google update".

So two suggestions:
1. run the updater at a lower priority so that it doesn't take over the machine
2. setup.exe should have the google name in it, so that people have
some idea what it is

---

He's running Windows (XP I think; I can check if it's important).

Original issue reported on code.google.com by mpearson@chromium.org on 14 Aug 2012 at 4:34

GoogleCodeExporter commented 9 years ago
Omaha already runs at BELOW_NORMAL priority class.  It will already opt into 
background processing for its I/O if you're on Vista or later.  (See 
goopdate\goopdate.cc @ 1398)

In the current build, all of Omaha's executables are named with a prefix of 
"GoogleUpdate":

GoogleUpdate.exe
GoogleUpdateBroker.exe
GoogleUpdateSetup.exe
GoogleUpdateReporter.exe

No product currently shipping via Omaha has a name of "setup.exe" -- they all 
use more descriptive executable names (for ex, 
%oldver%_%newver%_chrome_updater.exe, or gsync.msi).

You can verify that this was Omaha behavior by looking in the Windows Event 
Log; it logs there when it wakes up, does update checks, and launches processes.

Feel free to reopen the bug if you can actually isolate Omaha doing something 
unfriendly to the system :)

Original comment by ryanmyers@google.com on 14 Aug 2012 at 5:26

GoogleCodeExporter commented 9 years ago
Thanks for the detailed reply!

Original comment by mpearson@chromium.org on 14 Aug 2012 at 6:57

GoogleCodeExporter commented 9 years ago
> Feel free to reopen the bug if you can actually isolate
> Omaha doing something unfriendly to the system :)
Reopened. :)
because I have evidence that the previous answer is incorrect.

This setup.exe annoyed my dad again a couple of days ago so he installed 
Process Explorer.  Then the setup.exe happened again yesterday.  Here's what 
Process Explorer reported:
---
GoogleUpdate.exe        GoogleUpdate.exe        3172            7,452 K 3,472 K 
Google Installer       Google Inc.
22.0.1229.94_22.0.1229.92_chrome_updater.exe         
22.0.1229.94_22.0.1229.92_chrome_updater.exe    2948            536 K   156 K
setup.exe  setup.exe       3944    66.15   236,832 K       424,276 K       
Google Chrome       Google Inc.
---
Clearly this setup.exe is coming from Google with Chrome.

The problem is that setup.exe is running at "Priority - Normal - 8".

Also, immediately after he told me about this, I asked him to check 
about:version.  It reports Google Chrome   22.0.1229.94 (Official Build 161065) 
m, which is the stable update we pushed yesterday.

This evidence (the signature of setup.exe, the fact that immediately afterward 
my father's Chrome browser running an updated version) indicates that this is a 
google process.

Original comment by mpearson@chromium.org on 11 Oct 2012 at 10:23

GoogleCodeExporter commented 9 years ago
oops, this didn't seem to reopen the bug.  This bug is still marked 
"Closed/Invalid".  I'll file a new bug.

Original comment by mpearson@chromium.org on 11 Oct 2012 at 10:24

GoogleCodeExporter commented 9 years ago
Re-opened into bug 46
http://code.google.com/p/omaha/issues/detail?id=46

Original comment by mpearson@chromium.org on 11 Oct 2012 at 10:41