search

p-alik / perl-Gearman

9 stars 10 forks source link

Gearman-Client-Async tests hang since Gearman > 1.130.004 #10

Closed ppisar closed 7 years ago

ppisar commented 7 years ago

I noticed Gearman-Client-Async-0.94 started to fail tests after upgrading Gearmean from 1.130.004 to 2.002.003 https://rt.cpan.org/Public/Bug/Display.html?id=120306.

I bisected the failure to Gearman's commit:

commit 049bc8fb998759ec0435e2879a456064b9f28170
Author: Alexei Pastuchov <info@maximka.de>
Date:   Sun Jul 24 18:48:49 2016 +0200

    bug fix: worker provide all parameters to super

Do you have an idea if this is a bug in new Gearman or Gearman-Client-Async uses Gearman in a wrong way?

p-alik commented 7 years ago

Oh, I'm sorry. I'll fix it as soon as possible.

p-alik commented 7 years ago

@ppisar, what kind of gearmand do you use for testing purpose? gearman.org or Gearman::Server

ppisar commented 7 years ago

On Mon, Feb 20, 2017 at 12:56:16PM -0800, Алексей Пастухов wrote:

@ppisar, what kind of gearmand do you use for testing purpose? gearman.org or Gearman::Server

Gearman-Server-v1.130.1.

p-alik commented 7 years ago

After little changes commited in this branch allinone.t runs fine in my environment.

$ prove -I ../Gearman-Server/lib/ -I ../perl-Gearman/lib/ -lv t/allinone.t
t/allinone.t ..
1..2
ok 1 - Got both responses
ok 2 - 12 status messages
ok
All tests successful.

May you test it please.

ppisar commented 7 years ago

On Wed, Mar 01, 2017 at 11:54:17PM -0800, Алексей Пастухов wrote:

After little changes commited in this branch allinone.t runs fine in my environment. [...] May you test it please.

Thanks for the fix. I tested it and it works for me now.

-- Petr

p-alik commented 7 years ago

cool, thanks for testing. Bug fixing will be a part of next alpha _v2.003002, I'll release this evening.

p-alik commented 7 years ago

Since Gearman::Client v2.003.001 is released to CPAN the issue is done