Issue #22 showed some problems with interpolating airfoil curves from general point data with points_to_bspline (not the standard NACA4 or UIUC profile interpolation performed by the Airfoil class). Enforcing the trailing edge tangents to be equal to vector between the terminating points fixed this issue, and this should be added as an optional method in the Airfoil class.
I have not actually seen this issue with the Airfoil class, and suspect that it is caused by the scaling of points before interpolation, but not all airfoils in the UIUC database have been tested.
This may have knock on effects, since the last parameter of the curve is no longer 1 using this method (i.e., curve.Value(1) is not the end point).
Issue #22 showed some problems with interpolating airfoil curves from general point data with
points_to_bspline(not the standard NACA4 or UIUC profile interpolation performed by theAirfoilclass). Enforcing the trailing edge tangents to be equal to vector between the terminating points fixed this issue, and this should be added as an optional method in theAirfoilclass.I have not actually seen this issue with the
Airfoilclass, and suspect that it is caused by the scaling of points before interpolation, but not all airfoils in the UIUC database have been tested.This may have knock on effects, since the last parameter of the curve is no longer 1 using this method (i.e.,
curve.Value(1)is not the end point).