Is there any error in discriminator loss in GAIL?

p-christ / Deep-Reinforcement-Learning-Algorithms-with-PyTorch

PyTorch implementations of deep reinforcement learning algorithms and environments

MIT License

5.64k stars 1.2k forks source link

Is there any error in discriminator loss in GAIL? #74

Open Joywanglulu opened 3 years ago

Joywanglulu commented 3 years ago

I'm wondering if the loss of discriminator in GAIL could be "discrim_loss = discrim_criterion(g_o, zeros((states.shape[0], 1), device=device)) + \ discrim_criterion(e_o, ones((expert_traj.shape[0], 1), device=device))"

instead of "discrim_loss = discrim_criterion(g_o, ones((states.shape[0], 1), device=device)) + \ discrim_criterion(e_o, zeros((expert_traj.shape[0], 1), device=device))"?