p-connor / plasma-drawer

A customizable fullscreen launcher widget for KDE Plasma
83 stars 4 forks source link

Fixed uk and ru locales #60

Closed yaBobJonez closed 9 months ago

yaBobJonez commented 9 months ago

Good afternoon! I've been watching this repository and noticed that you have recently added a new feature to use Plasma icons (b42f2a6f3c1914dbea4501330ae064cb9f1d14a8), which is great! However, you have probably used machine/automated translation tools for the new string. If that's okay, I suggest such changes. Both of your original translations ending in -уйте are second-person plural imperative forms (in simpler terms, used for orders and commands, e.g. "Use!"). Here instead, it would be correct to use infinitives (ending in -ать and -ати respectively). Also, I changed "значки" into "иконки" for consistency with other strings I have previously added, even though both terms for "icons" are correct in Russian. Thank you again for your hard work! :)

p-connor commented 9 months ago

This is exactly what I was afraid of! Yes, I did unfortunately use an auto-translation tool, and was a bit worried about the quality. However, I figured you were long gone and I didn’t want to bother you by reaching out for a 3 word translation 😂. I realize now that was a bit foolish, from now on I will reach out and if you or some translator is not available I will simply leave the string untranslated.

I will merge this PR in and release the change sometime around 8pm PST (20:00 UTC-8) today. It will be a silent update (simply overwriting the 1.4 release file), so those who have already downloaded the update may have to download it again to get the change.

Thank you so much for your attentiveness!

p-connor commented 9 months ago

Change has been merged and new version of 1.4 file in the repo and on store.kde.org now contains the fix. You should be good to reinstall the widget and see the changes.

Let me know if there are any other concerns. Thanks!