search

p-costa / SNaC

A multi-block solver for massively parallel direct numerical simulations (DNS) of fluid flows
MIT License
39 stars 9 forks source link

Compilation failure with gnu compiler (in initmpi.f90) #36

Closed nscapin closed 2 years ago

nscapin commented 2 years ago

Hello @p-costa, just for your info. I tried to compile the master branch of SNaC and I couldn't since MPI_LONG in initmpi.f90 was not recognized from my GNU compiler. I just replaced with MPI_INTEGER and it works fine. Anyway, I thought it was worth mentioning.

p-costa commented 2 years ago

Thank you, @nscapin!

The issue is that, for very large systems, MPI_INTEGER results in overflow. However, since this variable is not used in the calculation but only for logging purposes, it may be worth reverting or finding a more clever solution.

Perhaps the best solution is to use MPI_Type_match_size.

nscapin commented 2 years ago

yes, it works for me! Thanks @p-costa.