p-e-w / GTKDarkThemeVariantSetter

Make Sublime Text use the dark GTK+ theme variant (NO LONGER MAINTAINED)
51 stars 5 forks source link

Not working #8

Open jdumas opened 8 years ago

jdumas commented 8 years ago

Hi,

I like the idea of this plugin, but it doesn't seem to be working. I am using Sublime Text 3, Build 3114. My GTK theme is Arc (tag 20160331), and I have both GTK 3.20.6 and GTK 2.24.30 (I'm running on Archlinux).

The problem is that Sublime seems to rely on GTK 2, since I can set its GTK theme by launching from command line with GTK2_RC_FILES=... subl3. However using the _GTK_THEME_VARIANT trick via xprop doesn't work, even though my theme has a dark variant (which I can see other programs — but not ST3 — follows if I set gtk-application-prefer-dark-theme=true in my gtk-3.0/settings.ini).

So now I wonder, how did you achieve the result from your screenshot with ST3? What ST Build and GTK theme are you using? Is your ST3 using GTK 3?

It would also be nice if we could set a different theme altogether for dark theme (for e.g. if the theme doesn't have a dark variant). I want to be able to switch between light and dark themes (e.g. depending on time of the day), so ideally I'd like to "update" the theme without restarting the ST3, or with little extra work. Are you aware of any trick that could do that?

p-e-w commented 8 years ago

Since the plugin works fine with Adwaita, I suspect that the fault lies with Arc somehow. Unfortunately, the only thing I know about GTK+ themes is that the underlying API changes every six months so I'm afraid that's all I can say here. :disappointed:

jdumas commented 8 years ago

I've tried it with Adwaita as well, but it doesn't work either. I'm changing my theme with lxappearance, and I think it's applying to both GTK 2 and GTK 3 applications. Sublime seems to respond to changes in the GTK 2 theme (via the GTK2_RC_FILES=... trick), and the scarse documentation around gtk-application-prefer-dark-theme=true suggests it has been introduced with GTK 3.

To be honest I'm even surprised it works on your computer! But I don't think there is much we can do indeed =/